Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add confirmation to Mac Next Steps card #1300

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

vkraucunas
Copy link
Contributor

@vkraucunas vkraucunas commented Dec 3, 2024

Asana Task/Github Issue: https://app.asana.com/0/1208403786889309/1208892824152048/f

Description

  • Adds handling for a confirmation state in the NextStepsCard, to handle the MacOS NTP use-case with “addAppToDockMac"

Testing Steps

  • Visit here
  • Click the action button in the Add App to Dock NextStepsCard. Should switch to text and icon saying “Added App to Dock!"
  • Clicking the action button in the Cookies NextStepCard should do nothing

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 8b37974
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/675b3ebbfcf0b3000890dbe6
😎 Deploy Preview https://deploy-preview-1300--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 3, 2024

[Beta] Generated file diff

Time updated: Thu, 12 Dec 2024 19:52:25 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js

File has changed

@vkraucunas vkraucunas force-pushed the vkraucunas/fix-next-steps-mac branch from 103484e to 9faf875 Compare December 4, 2024 01:49
@vkraucunas vkraucunas force-pushed the vkraucunas/fix-next-steps-mac branch from 8e6bb6d to 86a9ae8 Compare December 11, 2024 17:28
@vkraucunas vkraucunas marked this pull request as ready for review December 11, 2024 18:40
@vkraucunas vkraucunas requested review from shakyShane, mgurgel and a team as code owners December 11, 2024 18:40
@vkraucunas vkraucunas merged commit 21b31fe into main Dec 12, 2024
16 checks passed
@vkraucunas vkraucunas deleted the vkraucunas/fix-next-steps-mac branch December 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants